Switch URL for prog info scraping to use the OPO site #1662
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@mfixstsci, local testing shows that this is working well, so I think it's ready for review. |
mfixstsci
approved these changes
Dec 18, 2024
|
@bhilbert4 this is a good fix, thank you for submitting. I wonder if there is a more reliable API to use to obtain this same information instead of scraping websites 🤔 |
|
I started looking into getting the info from pyvo or mast, but there wasn't anything obvious in my quick check, so I moved on. I agree that if we can get the info that way, it would be better. I opened a JIRA ticket for that last night. |
|
add me to the ticket, I have a likely internal method, depends on what you want |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The site that JWQL had been using to scrape for proposal information went down last week, and is not yet back up. JWQL did not check for the internal server error returned for those pages, which was causing JWQL to crash when trying to load any observation-level page.
This PR switches over to use the OPO version of the proposal information pages. It also adds a check for an internal server error when scraping the page.
Resolves #1660